Skip to content

add auto-rotate button using detected guide lines - #21652

Closed
facorazza wants to merge 2 commits into
darktable-org:masterfrom
facorazza:feature/auto-rotate
Closed

add auto-rotate button using detected guide lines#21652
facorazza wants to merge 2 commits into
darktable-org:masterfrom
facorazza:feature/auto-rotate

Conversation

@facorazza

Copy link
Copy Markdown

Add an auto rotate button to the rotation slider that uses detected structure lines to compute the best rotation angle.

Also always apply the crop values in commit_params so the result is visible immediately without needing to leave the module

- commit crop values to params after the swap/history/swap cycle
- remove focus gate in commit_params so valid crop is always rendered
@ralfbrown ralfbrown added feature: new new features to add scope: UI user interface and interactions labels Jul 27, 2026
@TurboGit

Copy link
Copy Markdown
Member

Isn't this a duplicate of #21024?

@wpferguson

Copy link
Copy Markdown
Member

I tested this an it has several issues

  • I'm not sure a magic wand icon is the correct icon for this. The usual use for the magic wand is making a selection
  • If the R&S module is open when you load an image into darkroom pressing the icon has no effect. Pressing it a second time does the rotation. Collapsing the module does a second rotation.
  • Sometime the action doesn't perform the crop.
  • Sometimes the structure lines remain after the module is closed
  • Sometimes the structure lines remain after the rotation is applied and the image is cropped.

I tested for about 5 minutes and only got it to work correctly once or twice.

@facorazza

Copy link
Copy Markdown
Author

Isn't this a duplicate of #21024?

yes this is a duplicate sorry

@facorazza facorazza closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: new new features to add scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants