colorcalibration also for manual wb - #20304

Draft

kofa73 wants to merge 18 commits into

darktable-org:masterfrom

kofa73:colorcalibration-also-for-manual-wb

Commits on Aug 19, 2026

wb: added new param late_correction to temperature.c, exposed as a checkbox; populate dev->chroma->late_correction based on checkbox-driven late_correction flag for 'legacy' modes (DT_IOP_TEMP_AS_S…
kofa73
committed
bc01df2
wb: Updated the rest of the files, but channelmixerrgb is broken, everything is purple.
kofa73
committed
6b04bcd
wb: Undid changes to channelmixerrgb.c, will go carefully next time
kofa73
committed
35b817c
wb: Fixed publishing of late_correction in temperature.c
kofa73
committed
24899c3
wb: added DT_ILLUMINANT_FROM_WB, separated find_temperature_from_raw_coeffs into find_temperature_from_wb_coeffs, find_temperature_from_as_shot_coeffs; added handling to channelmixerrgb.c + altered…
kofa73
committed
2c443d5
wb: fix switch-case fall-through in illuminants.h#illuminant_to_xy; validate wb_coeffs for find_temperature_from_wb_coeffs as well as in find_temperature_from_as_shot_coeffs; fix copy-pasted commen…
kofa73
committed
ab1a4d4
wb: safe division in _get_d65_correction_ratios
kofa73
committed
7530b07
wb: added _get_corrected_illuminant_xy to deduplicate repeated code
kofa73
committed
29a205b
wb: fix illuminants.h switch-case fall-through introduced when DT_ILLUMINANT_CAMERA was added
kofa73
committed
cdaa952
wb: renamed find_temperature_from_... to find_illuminant_xy_from_...; comment maintenance
kofa73
committed
ea769bb
Doc updates
kofa73
committed
83b61a0
Doc updates: wb + color calibration
kofa73
committed
f846b98
wb: removed 'as-shot to reference' (same as 'as shot' + 'prepare data for color calibration' (late_correction)); fixed behaviour when WB disabled; removed unused code
kofa73
committed
abf1912
wb: make sure color calibration / white balance warning is shown when WB disabled
kofa73
committed
e9e0d95
wb: don't modify p->x, p->y in _preview_pipe_finished_callback; switch left-over gui->reset to DT_ENTER|LEAVE_GUI_UPDATE
kofa73
committed
8fd3003
wb: minor clean-up in channelmixerrgb (GUI struct field names for clarity), no need to allocate + copy xy in illuminants.h find_illuminant_xy_from_wb_coeffs; no need for 0 check after isnormal
kofa73
committed
56279bc
wb: opposed.c hash: late_correction is a param of temperature (is before opposed), so already part of hash
kofa73
committed
7efdf9a
wb: tiny clean-up: unnecessary parens, accidental duplication
kofa73
committed
0e66d2a

Navigation Menu

colorcalibration also for manual wb - #20304

colorcalibration also for manual wb#20304
kofa73 wants to merge 18 commits into
darktable-org:masterfrom
kofa73:colorcalibration-also-for-manual-wb

Commits on Aug 19, 2026

wb: added new param late_correction to temperature.c, exposed as a checkbox; populate dev->chroma->late_correction based on checkbox-driven late_correction flag for 'legacy' modes (DT_IOP_TEMP_AS_S…

wb: Updated the rest of the files, but channelmixerrgb is broken, everything is purple.

wb: Undid changes to channelmixerrgb.c, will go carefully next time

wb: Fixed publishing of late_correction in temperature.c

wb: added DT_ILLUMINANT_FROM_WB, separated find_temperature_from_raw_coeffs into find_temperature_from_wb_coeffs, find_temperature_from_as_shot_coeffs; added handling to channelmixerrgb.c + altered…

wb: fix switch-case fall-through in illuminants.h#illuminant_to_xy; validate wb_coeffs for find_temperature_from_wb_coeffs as well as in find_temperature_from_as_shot_coeffs; fix copy-pasted commen…

wb: safe division in _get_d65_correction_ratios

wb: added _get_corrected_illuminant_xy to deduplicate repeated code

wb: fix illuminants.h switch-case fall-through introduced when DT_ILLUMINANT_CAMERA was added

wb: renamed find_temperature_from_... to find_illuminant_xy_from_...; comment maintenance

Doc updates

Doc updates: wb + color calibration

wb: removed 'as-shot to reference' (same as 'as shot' + 'prepare data for color calibration' (late_correction)); fixed behaviour when WB disabled; removed unused code

wb: make sure color calibration / white balance warning is shown when WB disabled

wb: don't modify p->x, p->y in _preview_pipe_finished_callback; switch left-over gui->reset to DT_ENTER|LEAVE_GUI_UPDATE

wb: minor clean-up in channelmixerrgb (GUI struct field names for clarity), no need to allocate + copy xy in illuminants.h find_illuminant_xy_from_wb_coeffs; no need for 0 check after isnormal

wb: opposed.c hash: late_correction is a param of temperature (is before opposed), so already part of hash

wb: tiny clean-up: unnecessary parens, accidental duplication