Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALNHTTPClient already delivers raw streaming chunks, but apps still need to split SSE lines and events themselves. This adds an independent
ALNSSEReaderthat accepts arbitrary chunks and delivers immutableALNSSEEventvalues inline, with default 64 KiB line and 1 MiB event-data bounds.The reader handles split UTF-8/BOM, CR/LF/CRLF, multiline data, event types and persistent/reset IDs. Limits are checked before buffer growth; errors and handler stops are permanent. Completed lines use strict UTF-8 validation rather than browser-style replacement decoding. EOF discards incomplete events. The HTTP guide includes HelpDesk's requirement that apps must see their own terminal event: HTTP success and parser finish alone cannot prove application completion.
Validation:
tools/source_gnustep_env.sh; used the pinned vendored XCTest runner.make test-unit-filter TEST=SSEReaderTests ARLEN_TEST_JUNIT=1: 16 methods pass, zero failures/errors/skips. Includes every two-chunk split and byte-by-byte input, malformed UTF-8, byte boundaries, stop/EOF behavior, reentrancy and a large multi-event chunk.make test-inventory: all 1675 discovered methods match the baseline (1409 unit, 266 integration); this check lists tests without running the full suites.make docs-api docs-html ci-docs: passes; generated public API docs and newcomer references are updated.Refs #332. Draft for v0.4.0 consideration, based on main
e26a755e. No HTTP transport, ALNRequest or search changes; no automatic retry/reconnect, vendor terminal semantics, CI lane changes or ABI/runtime-pin changes. Existing v0.3.2 worktrees and evidence are preserved. No milestone assigned; no merge, tag or publishing requested.Follow-up static analysis: commit
e0a73db5moves writes to the autoreleasing NSError output parameter outside the per-line pool. The same 16 focused tests pass. The local full scan-build run now reports zero SSE findings; its overall gate fails on two findings in unchanged files (ALNAuthModule.m:3345andALNHTTPServer.m:2714) that were absent from the original PR CI report. No analyzer baseline, suppressions or exclusions changed. Normal PR CI will verify the updated head on its existing runners.