fix(actix-web/deps): clean up transitive dependencies - #13
Merged
danielkov merged 2 commits intoAug 1, 2026
Merged
Conversation
Contributor
Author
|
As a bonus, this crate could theoretically be made |
Owner
|
Hey @AverageHelper , thank you for your contribution (and for enabling maintainer edits). I formatted your changes with: |
danielkov
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor dependency clean-up in
actix-web-helmet, as described in #12:default-features = falseforactix-web(helmet only uses themacrosfeature, and then only while testing)futuresin favor ofcore::futurestructures.I'm not sure if removing
futuresis considered "breaking" under normal circumstances, but I tested the change successfully against a local crate and needed no code changes afterward, so I figure it's fine as long as no one manually interacted with the middleware, or if they did, did not depend on the specific minor differences betweenfutures' and Rust core'sReady.Otherwise, simply setting
default-features = falseforfutureswould also work.Fixes #12