Repository navigation
refactor: apply go fix modernizations - #1153
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 94.73% 94.72% -0.01%
==========================================
Files 25 25
Lines 5200 5193 -7
==========================================
- Hits 4926 4919 -7
Misses 269 269
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
go fixagainst the go 1.26 toolchain and tidied what it left behind. No behaviour changes; the full test suite passes.wait.Goclosures inhumafiber_v2_context_test.goneed//nolint:testifylint. testifylint only skips assertions inside a literalgostatement, and switching torequirewould callFailNowoff the test goroutine. The latest testifylint (v1.6.4) still doesn't handle this.ModifyOperationdrops the inline closure that was only there to capture the loop variable before Go 1.22. Then := chaincopy is still needed so the closure doesn't call itself.Ptrtest helper is gone;new(expr)replaces it.