Skip to content

refactor: apply go fix modernizations - #1153

Merged
robtme merged 1 commit into
mainfrom
refactor/go-fix
Oct 27, 2026
Merged

robtme merged 1 commit into
mainfrom
refactor/go-fix

Conversation

@robtme

@robtme robtme commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Ran go fix against the go 1.26 toolchain and tidied what it left behind. No behaviour changes; the full test suite passes.

  • The wait.Go closures in humafiber_v2_context_test.go need //nolint:testifylint. testifylint only skips assertions inside a literal go statement, and switching to require would call FailNow off the test goroutine. The latest testifylint (v1.6.4) still doesn't handle this.
  • ModifyOperation drops the inline closure that was only there to capture the loop variable before Go 1.22. The n := chain copy is still needed so the closure doesn't call itself.
  • The Ptr test helper is gone; new(expr) replaces it.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.72%. Comparing base (4035252) to head (a6efaaa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   94.73%   94.72%   -0.01%     
==========================================
  Files          25       25              
  Lines        5200     5193       -7     
==========================================
- Hits         4926     4919       -7     
  Misses        269      269              
  Partials        5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robtme
robtme merged commit 22bef3d into main Oct 27, 2026
7 checks passed
@robtme
robtme deleted the refactor/go-fix branch October 27, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant