Repository navigation
test(dev): build the dev image and libmxl tests from one libmxl - #22
Merged
Merged
Conversation
dev/Dockerfile took libmxl from go-mxl 1.1.0-rc.7 while dev/libmxl.sh checked out f1033fa3, so the image and the test suite ran different builds. Both now follow go-mxl 1.1.0-rc.14, which is qvest-digital/mxl 121615e3. tools/setcheck moves with them.
danielclasen
force-pushed
the
test/libmxl-pin-rc14
branch
from
November 9, 2026 09:39
901fbcf to
e28d58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev/Dockerfile took libmxl from go-mxl 1.1.0-rc.7 while dev/libmxl.sh built f1033fa3. Both now follow go-mxl 1.1.0-rc.14 (qvest-digital/mxl 121615e3), as does tools/setcheck (Dockerfile, go.mod, go.sum). setcheck builds, vets and passes its tests in the rc.14 builder image. The type is test so release-please cuts no release. The libmxl-based VM test scripts were not run locally.