Extension numbers 1374 and 1375, durable's registered allocation - #99
Merged
Merged
Conversation
The step and pipeline message options move off the 51841/51842 organization-internal numbers onto the two the protobuf global extension registry now lists for durable (protocolbuffers/protobuf docs/options.md). Generated descriptors regenerate; a proto compiled against the old numbers must be regenerated to be seen by the generator and the runtime.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protobuf global extension registry now lists durable at 1374-1375 (protocolbuffers/protobuf
docs/options.md, requested in protocolbuffers/protobuf#29568).durable.v1.stepbecomes 1374 anddurable.v1.pipeline1375, replacing the 51841/51842 numbers from the organization-internal range, and the placeholder note inoptions.protogoes with them.Generated descriptors are regenerated (
durablepband the five example packages).buf breakingagainst master passes. Any pipeline proto compiled against the old numbers has to be regenerated: its descriptor carries the options under 51841/51842, where neither the generator nor the runtime looks any more.