Steps nest in their pipeline message; the steps list is gone - #95
Merged
Merged
Conversation
The wiring snippet had a stray paren from the last edit and the prose still promised per-step Func adapters. The example now shows the pipeline interface end to end — select, reserve with its unwind, create with a permanent failure, reduce — then wiring, the three ways a Wait ends, restart, and testing.
A pipeline is a top-level message with the pipeline option; its steps are the messages nested directly in it, in declaration order, which is the topology. Nothing lists a step twice, a step belongs to one pipeline by construction, and two pipelines in a package may name their steps alike. The step's Go type is protoc-gen-go's nested name, Pipeline_Step; its handler method is the short name. Generation rejects a step outside a pipeline, a non-step nested in one, or a pipeline that is not top-level. PipelineOptions loses its steps field. Examples, README, tour, and spec 02 and 05 rewritten to the nested form; the flyd stop port follows on its branch.
This was referenced Sep 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pipeline is a top-level message with the pipeline option; its steps are the messages nested directly in it, in declaration order, which is the topology:
Pipeline_Step(*machinespb.ProvisionMachine_SelectHost,machinespb.ProvisionMachine_SelectHostStep); the handler method stays the short name. Input and output remain referenced top-level messages, since callers hold those types.PipelineOptions.stepsis removed.Examples, README (this includes #94's rewrite), tour, and spec 02 and 05 are in the nested form. Breaking for every proto: move the step messages inside the pipeline and drop the list; regenerate; rename state types to
Pipeline_Step.