Repository navigation
Bound HTTP probes so readiness checks can retry - #513
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
RequestBuilderWhy
The failure in #509 was not caused by Mockito. The pod, Service endpoint, Docker port mapping, and in-container NodePort path were all healthy by diagnostic time. The first host-side request had instead remained blocked for the entire Awaitility window because
TinyHttpClienthad no connection or read timeout.The regression test reproduces the blocking behavior without relying on a timing-sensitive Kubernetes or iptables race. A connect-blackhole test would depend on host routing and firewall behavior, so the local accepted-but-unresponsive socket is the deterministic CI fixture.
Verification
The full Kubernetes version matrix is expected to exercise the updated NodePort probe. The focused regression test verifies that a stalled attempt fails within the configured bound and a later attempt succeeds.
Related to #509, but intentionally kept separate from the Mockito dependency update.