Fix PaccMann integration#447
Open
tereshchuk1 wants to merge 8 commits into
Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #447 +/- ##
===============================================
+ Coverage 80.34% 81.11% +0.77%
===============================================
Files 101 127 +26
Lines 8171 10057 +1886
===============================================
+ Hits 6565 8158 +1593
- Misses 1606 1899 +293 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the PaccMann implementation originally submitted in #388 by @gretag04, adapting it to work within the drevalpy framework.
Bug fixes
pytodaimports inpaccmann_v2.py:import pytodaandfrom pytoda.smiles.transforms import AugmentTensorwere imported at the top level butpytodais not a drevalpy dependency. Imports are now lazy (inside theconfidence=Truebranch only), using the bundled stub inPaccMann/pytoda/.