Repository navigation
fix(adopt): an imported project's Open link goes to the service with a web page, not its database - #196
Open
ahze wants to merge 1 commit into
Open
fix(adopt): an imported project's Open link goes to the service with a web page, not its database#196ahze wants to merge 1 commit into
ahze wants to merge 1 commit into
Conversation
…a web page, not its database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopting a compose project wrote web_port from whichever of its containers podman listed first. For mealie that was postgres, so the stack's Open link went to port 5432.
adoptWebHint now looks at the imported project whole, in compose order: a service running the catalog app's image gives the manifest's web_port, else the first exposed TCP port of a service's image, with databases (updates.DataTiedToMajor plus mysql, mariadb, percona, redis, valkey, memcached) passed over. The port is the host port the service publishes it on.
The choice is a pure helper, webHint, with tests built from mealie's real compose and exposed ports.