Repository navigation
feat(install): daemonless services get the color startup banner on both engines - #195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every daemonless service fjord installs gets DAEMONLESS_BANNER=color in its container environment, on both engines, so the Logs tab shows the full-color startup logo.
Since base-core ea30a34 the banner is mono by default: appjail logs read pipes through less, which takes the color logo for a binary file and stops on a prompt. fjord reads logs without a pager and its log pane renders 24-bit color, so it can ask for color.
Checked on netlab with zensical on podman and on AppJail through the new test/ui/banner (14/14): the logo in color with no gap between rows, the variable in podman inspect and in the jail's process environment, and DAEMONLESS_BANNER=plain written on the .env tab kept through Apply.