Skip to content

🎨 Palette: Add explicit label associations for layer filters#313

Open
d3mocide wants to merge 1 commit into
devfrom
palette-a11y-filter-labels-14909401266047224618
Open

🎨 Palette: Add explicit label associations for layer filters#313
d3mocide wants to merge 1 commit into
devfrom
palette-a11y-filter-labels-14909401266047224618

Conversation

@d3mocide
Copy link
Copy Markdown
Owner

💡 What: Added explicit htmlFor attributes to <label> elements and matching id attributes to their nested <input> checkboxes across LayerFilters.tsx, LayerVisibilityControls.tsx, and SystemSettingsWidget.tsx.

🎯 Why: While wrapping an input inside a label creates an "implicit" association that is technically valid HTML, adding the explicit id/htmlFor mapping is a highly recommended accessibility best practice. It ensures maximum compatibility with older or less capable screen readers and assistive technologies that sometimes struggle with implicit labels alone.

📸 Before/After: This is an invisible DOM change, no visual updates.

Accessibility: Enhanced screen-reader robustness for the numerous custom toggles in the map layer filters and settings widgets.


PR created automatically by Jules for task 14909401266047224618 started by @d3mocide

Added explicit `htmlFor` attributes to `<label>` elements and matching `id` attributes to their nested `<input>` checkboxes across filter and setting widgets to improve screen reader compatibility and overall accessibility.

Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant