ci: add required test and container gates - #65
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 178b2cf689
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Independent review — FortiPath PR #65Exact head: Scope verified in diff
Node evidence (local on g8s-node-2)
CI run 29732010720
Verdict: PASSAll node evidence and CI jobs (except the draft-PR gate) pass. The |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cabd59ecb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
validateworkflow with real unit, container-smoke, exact-head independent-review, and aggregateRequired CIjobscodex/*, a non-draft PR, and genuine exact-head review evidenceValidation
Executed on g8s-node-2 at exact head
2d6b57203bd72a271ff40912386a25b6a82bfc50:scripts/.github/workflows/spec-kit.ymlgit diff --checkpassedGITHUB_TOKENhealthy, served the root route, the nested/FortiPath/route, and an emitted asset, and ran as non-root UID 101Agent quality evidence
node2-codex-2d6b5722d6b57203bd72a271ff40912386a25b6a82bfc50.G1-Maria/direct-17845481742d6b57203bd72a271ff40912386a25b6a82bfc50: no P1 or P2 findings; the only release-gate failure reported was this row's previously stale SHA, now corrected.node2-tests-2d6b5722d6b57203bd72a271ff40912386a25b6a82bfc50: missing-secret fail-closed check, secret-backed image build, generated-data validation, mock-data exclusion, token non-persistence, unit, actionlint, container route/asset/non-root checks, and diff check.Risk and follow-up
The GitHub Actions token is scoped to the workflow and exposed only to the single fetch/build step through BuildKit's ephemeral secret mount. It is not declared through
ARGorENV, and only generated static assets are copied into the runtime image. The existing site dependency graph nevertheless reports known build-time advisories and needs a separately reviewed framework migration. The aggregate intentionally fails closed for drafts, non-codex/*branches, stale review evidence, or any failed validation job.Rollback: revert this PR's squash commit. No branch-protection relaxation or runtime credential rotation is included.