Fix PayNyms: use PayNym.rs#1294
Merged
Merged
Conversation
wrap jsonDecode(response.body) in a try/catch with isEmpty guard to prevent FormatException when paynym.rs returns non-200 with empty body
TODO: refactor `paynym_is`->`paynym_rs` chore: dart format
as of bdc0c0788d1d6dfb04863a793955f848ba1624a8 see 783dbde
julian-CStack
previously approved these changes
May 13, 2026
Collaborator
julian-CStack
left a comment
julian-CStack
left a comment
There was a problem hiding this comment.
LGTM but I haven't run/tested personally yet
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1294 +/- ##
===========================================
+ Coverage 4.82% 4.93% +0.10%
===========================================
Files 1064 1064
Lines 107921 107980 +59
===========================================
+ Hits 5208 5328 +120
+ Misses 102713 102652 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julian-CStack
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
or we could separate P2TR support out and just fix existing functionality by resetting fix/paynym to e2754ad