Skip to content

ci: validate the manifest, check the docs, and run skill script tests - #17

Merged
cwkang1998 merged 3 commits into
mainfrom
chore/ci-checks
Nov 15, 2026
Merged

cwkang1998 merged 3 commits into
mainfrom
chore/ci-checks

Conversation

@cwkang1998

@cwkang1998 cwkang1998 commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Adds the three kinds of check upstream runs on pstack in cursor/plugins, ported to OMP. scripts/validate-plugin.mjs checks the OMP manifest in package.json: a kebab-case name, a semantic version, an omp manifest, and that every path in OMP's path fields (extensions, skills, tools, hooks, commands, top level and per feature) exists inside the package. OMP publishes no manifest schema, so these are the fields its loader reads. scripts/check-pstack-docs.mjs ports upstream's docs check to README.md. It covers /skill: commands, other harnesses' $name, /name and /pstack:name forms, links and anchors, count claims, agent names, and a README link for every skill, playbook, and agent. Upstream's model-name check is left out because setup-pstack has no default models. The README gains those tables, using upstream's rows where the skill is shared, and now invokes skills as /skill:<name>. npm run test:skills runs skills/*/scripts/test/*.test.ts as upstream's CI does. The statechart symlink test now builds its fixture from the real temp path, so it passes on macOS. A new validate.yml workflow runs every check on pull requests and pushes to main. The sync workflow runs the new checks too, and when only the docs check fails it opens its pull request as a draft with the docs-check log in the body.

Base automatically changed from sync/upstream-0.15.42-selected to main November 15, 2026 22:36
Port upstream's checks from cursor/plugins. scripts/validate-plugin.mjs checks the OMP manifest in package.json: a kebab-case name, a semantic version, an omp manifest, and that each declared path exists. OMP publishes no manifest schema, so it checks the fields OMP's loader reads.
scripts/check-pstack-docs.mjs ports check-pstack-docs.mjs to README.md. It checks /skill: commands, links and anchors, count claims, agent and model names, and that the README links every skill, playbook, and agent. It also flags $<skill>, which OMP does not run.
The README gains playbook, skill, principle, and agent tables, reusing upstream's rows where the fork has the same skill. It now invokes skills with /skill:.
test:skills runs skills/*/scripts/test/*.test.ts like upstream's CI. The statechart symlink test now builds its fixture from the real temp path, so it passes on macOS, where /var is a symlink.
.github/workflows/validate.yml runs every check on pull requests and pushes to main. The sync workflow runs the new checks before it opens its pull request.
Restore the README code fence, and have verify scan README.md again for skill:// and named-skill references.
validate-plugin uses the semver.org pattern and checks every relative path in the omp manifest, including string fields and feature entries.
check-pstack-docs flags /name and /pstack:name as well as $name, and drops upstream's model-name check, since setup-pstack has no default models to compare with.
The sync workflow opens a draft pull request listing the docs failures when only the docs check fails, so a new upstream skill gets its README row on that branch.
…PRs in draft

validate-plugin checks extensions, skills, tools, hooks, and commands at the top level and in each feature, whatever the path's spelling, so bare and absolute paths no longer slip through.
The sync workflow puts the whole docs-check log in the PR body, so a checker crash with no FAIL lines still opens the PR, and uses always-true so an existing sync PR also returns to draft.
@cwkang1998
cwkang1998 merged commit afac88c into main Nov 15, 2026
1 check passed
@cwkang1998
cwkang1998 deleted the chore/ci-checks branch November 15, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant