Repository navigation
ci: validate the manifest, check the docs, and run skill script tests - #17
Merged
Merged
Conversation
Port upstream's checks from cursor/plugins. scripts/validate-plugin.mjs checks the OMP manifest in package.json: a kebab-case name, a semantic version, an omp manifest, and that each declared path exists. OMP publishes no manifest schema, so it checks the fields OMP's loader reads. scripts/check-pstack-docs.mjs ports check-pstack-docs.mjs to README.md. It checks /skill: commands, links and anchors, count claims, agent and model names, and that the README links every skill, playbook, and agent. It also flags $<skill>, which OMP does not run. The README gains playbook, skill, principle, and agent tables, reusing upstream's rows where the fork has the same skill. It now invokes skills with /skill:. test:skills runs skills/*/scripts/test/*.test.ts like upstream's CI. The statechart symlink test now builds its fixture from the real temp path, so it passes on macOS, where /var is a symlink. .github/workflows/validate.yml runs every check on pull requests and pushes to main. The sync workflow runs the new checks before it opens its pull request.
cwkang1998
force-pushed
the
chore/ci-checks
branch
from
November 15, 2026 22:36
3c2d3e0 to
f62a654
Compare
Restore the README code fence, and have verify scan README.md again for skill:// and named-skill references. validate-plugin uses the semver.org pattern and checks every relative path in the omp manifest, including string fields and feature entries. check-pstack-docs flags /name and /pstack:name as well as $name, and drops upstream's model-name check, since setup-pstack has no default models to compare with. The sync workflow opens a draft pull request listing the docs failures when only the docs check fails, so a new upstream skill gets its README row on that branch.
…PRs in draft validate-plugin checks extensions, skills, tools, hooks, and commands at the top level and in each feature, whatever the path's spelling, so bare and absolute paths no longer slip through. The sync workflow puts the whole docs-check log in the PR body, so a checker crash with no FAIL lines still opens the PR, and uses always-true so an existing sync PR also returns to draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three kinds of check upstream runs on pstack in
cursor/plugins, ported to OMP.scripts/validate-plugin.mjschecks the OMP manifest inpackage.json: a kebab-case name, a semantic version, anompmanifest, and that every path in OMP's path fields (extensions,skills,tools,hooks,commands, top level and per feature) exists inside the package. OMP publishes no manifest schema, so these are the fields its loader reads.scripts/check-pstack-docs.mjsports upstream's docs check toREADME.md. It covers/skill:commands, other harnesses'$name,/nameand/pstack:nameforms, links and anchors, count claims, agent names, and a README link for every skill, playbook, and agent. Upstream's model-name check is left out becausesetup-pstackhas no default models. The README gains those tables, using upstream's rows where the skill is shared, and now invokes skills as/skill:<name>.npm run test:skillsrunsskills/*/scripts/test/*.test.tsas upstream's CI does. The statechart symlink test now builds its fixture from the real temp path, so it passes on macOS. A newvalidate.ymlworkflow runs every check on pull requests and pushes tomain. The sync workflow runs the new checks too, and when only the docs check fails it opens its pull request as a draft with the docs-check log in the body.