Repository navigation
build(docs): pin hast-util-raw to 9.1.0 until doc-kit handles whitespace in table heads - #139
Merged
Merged
Conversation
…ace in table heads hast-util-raw 9.1.1 and 9.2.0 moved to parse5 8, which keeps the whitespace text nodes around a table's header row. doc-kit's react generator reads thead.children[0] as the row, so the docs build now throws on docs/pages/translate.md. The repo has no lockfile, so every docs build picked up the new version, on main as well as in PRs.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docs build fails on main and on every Dependabot PR (failing run) with
TypeError: Cannot read properties of undefined (reading 'map'). hast-util-raw 9.1.1 and 9.2.0, both published 2026-11-06, moved from parse5 7 to parse5 8. A table'stheadnow keeps the whitespace text nodes around its row, so its children are[text, tr, text]. doc-kit's react generator readsthead.children[0].childrenas the header row, which breaks on the table indocs/pages/translate.md. The repo has no lockfile, so every docs build resolved the new version.This adds an npm override that pins hast-util-raw to 9.1.0, the last release on parse5 7. With it, a clean
npm install --workspaces=false && npm run docspasses again, and the lint and types jobs pass as before. Upgrading @doc-kit/generator-react doesn't fix it: 0.5.3 has the same line and fails differently on this config. The override can go once doc-kit skips whitespace nodes in table heads.