Repository navigation
fix(opt): list luxon as a dependency - #138
Merged
Merged
Conversation
index.js requires luxon and the published types import it, but it was only a devDependency, so installing @nodevu/opt alone threw "Cannot find module 'luxon'". Fixes #120
bnb
approved these changes
Nov 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
Changed
luxonmoves fromdevDependenciestodependenciesinopt/package.json, at the^3.5.0rangecoreuses.opt/index.jsrequires it at runtime.Added
@types/luxonindependencies, ascorehas it, becauseopt/types/index.d.tsimports fromluxon.opt/index.jsrequires is listed independencies. It fails without this change.How it was tested
npm packofopt, installed alone in an empty project, thenrequire('@nodevu/opt')(): main throwsCannot find module 'luxon', this branch returns the options.npm run coverage -w optpasses 11 tests at 100%, andnpm run lintandnpm run typespass. The other packages were checked for the same gap and have none:aliases,fetchindex,parsefiles,staticandtranslaterequire nothing at runtime, andcore,newest,oldestandrangeslist what they require.