Skip to content

fix(release): bump the pre-commit hook and the README schema URL on release PRs - #32

Merged
bnb merged 1 commit into
mainfrom
bnb/release-pr-bumps
Nov 2, 2026
Merged

bnb merged 1 commit into
mainfrom
bnb/release-pr-bumps

Conversation

@botandbang

Copy link
Copy Markdown
Contributor

tools/release-pr-cargo.sh bumped Cargo.toml and Cargo.lock on the release PR, but not .pre-commit-hooks.yaml, which the_pre_commit_hook_installs_this_version requires to match the crate's version, or the README's $schema URL, which is pinned to the release tag. With #30 at 0.2.0, that test would fail on the release PR and then on main.

Changed:

  • The script also rewrites @docov/cli@<version> in .pre-commit-hooks.yaml and the tag in the README's schema URL. It commits only when something changed, so a rerun is still a no-op.
  • The commit author's email used 41898283. github-actions[bot]'s id is 41898282, as action/docov.sh has it.
  • The comments in release.yml and .pre-commit-hooks.yaml say what the script bumps.

Checked: in a scratch worktree with package.json at 0.2.0, the bump commits Cargo.toml, Cargo.lock, .pre-commit-hooks.yaml and README.md, and a second run prints "already at 0.2.0". The hook test passes. With the hook left at 0.1.1, as the old script left it, the test fails.

@bnb
bnb merged commit 18db5ae into main Nov 2, 2026
9 checks passed
@bnb
bnb deleted the bnb/release-pr-bumps branch November 2, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants