Skip to content

chore: pin semantic-release plugin versions - #650

Merged
mahmoud-elmorabea merged 1 commit into
mainfrom
mbl-2324-rn-pin-semantic-release-plugins
Sep 2, 2026
Merged

chore: pin semantic-release plugin versions#650
mahmoud-elmorabea merged 1 commit into
mainfrom
mbl-2324-rn-pin-semantic-release-plugins

Conversation

@mahmoud-elmorabea

Copy link
Copy Markdown
Contributor

Problem

deploy-sdk.yml passes an extra_plugins list to cycjimmy/semantic-release-action. Unpinned entries there are installed at latest at release time, so the release pipeline's behaviour changes without any commit to this repo. That has already broken releases twice:

Both incidents are already fixed. What remained is that #639 pinned only semantic_version and the changelog preset — @semantic-release/github and @semantic-release/exec were still unpinned, leaving the same failure mode live.

What changed

Pinned the two remaining floating entries to the versions the workflow already resolves today, matching the style of the existing preset pin:

Plugin Before After
@semantic-release/github unpinned (latest) 12.0.9
@semantic-release/exec unpinned (latest) 7.1.0

Both are the current latest on npm and both predate the most recent successful release run (33205068114, 6.10.0, Aug 28), so this pins to what CI is already installing — no behaviour change, just determinism. Peer ranges (semantic-release: >=24.1.0) are satisfied by the pinned semantic_version: 25.0.9.

@semantic-release/changelog and @semantic-release/git are also used by .releaserc.json but are not listed here — they are bundled by cycjimmy/semantic-release-action itself, which is already SHA-pinned, so they are deterministic.

Dependabot blind spot

.github/dependabot.yml watches only github-actions, which resolves uses: refs and nothing else. No Dependabot ecosystem parses extra_plugins, so these versions are invisible to automated updates and will go stale with no PR.

I did not change dependabot.yml: there is no configuration that would actually cover these strings (adding an npm ecosystem would open PRs for the SDK's own dependency tree and still would not read the workflow). Instead the constraint is recorded as a comment next to the pins so the next person bumps them deliberately.

Out of scope

  • The orphan 6.6.0 tag (npm jumps 6.5.2 → 6.6.1) is intentionally left alone.
  • The post-release sample-app job is unchanged. This repo is the healthy reference for MBL-2324 — it takes an sdk_version input rather than using git describe, and that behaviour is deliberately preserved.

Fixes MBL-2324

@semantic-release/github and @semantic-release/exec were the last unpinned
entries in extra_plugins, so each release resolved whatever npm called latest
at that moment. Pin them to the versions the workflow already resolves today.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • Android APN: 650.1.0 (29803099)
  • iOS FCM: 650.1.0 (29803099)

@mahmoud-elmorabea
mahmoud-elmorabea marked this pull request as ready for review September 1, 2026 19:58
@mahmoud-elmorabea
mahmoud-elmorabea requested a review from a team as a code owner September 1, 2026 19:58

@Shahroz16 Shahroz16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The semantic-release plugins are pinned to compatible versions, the install replay resolves cleanly, and the action-provided changelog and git plugins are already pinned as well.

@mahmoud-elmorabea
mahmoud-elmorabea merged commit e670d6c into main Sep 2, 2026
17 checks passed
@mahmoud-elmorabea
mahmoud-elmorabea deleted the mbl-2324-rn-pin-semantic-release-plugins branch September 2, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants