Skip to content

feat(pstack): make poteto-mode's PR readiness configurable - #1228

Draft
mstephenholl wants to merge 1 commit into
cursor:mainfrom
mstephenholl:pstack-pr-readiness
Draft

mstephenholl wants to merge 1 commit into
cursor:mainfrom
mstephenholl:pstack-pr-readiness

Conversation

@mstephenholl

Copy link
Copy Markdown
Contributor

Why

This lets a user choose whether a poteto-mode run ends with a draft PR or a ready one. Opening a PR says to open every PR ready, never as a draft, so a user or team that wants drafts has no setting for it. Ready stays the default, which keeps the protection against PR tools that open drafts on their own.

What changed

  • Readiness in opening-a-pr.md reads a pull requests line from the pstack-models.mdc rule. draft opens drafts. A request in the task wins over the line, and a missing line means ready. multi-phase-plan, babysit, and shipping follow Readiness.
  • /setup-pstack asks for the value and writes the line. The Claude Code adapter and the README name it, and the harness tree is regenerated.

Scope

  • Nothing changes for a user who does not add the line.
  • Babysit passes --allow-draft to watch-pr for a draft, so it leaves the draft as it is. A playbook that merges marks a draft ready right before the merge.
  • The text does not name Origin's draft flag, because I could not confirm it. It sends the agent to origin pr create --help instead.

Tradeoffs

  • The setting is a line in the models rule, not a new rule. Every skill already reads that rule, and /setup-pstack already writes it.

Blast Radius

Runs that open, babysit, or ship PRs read the new text. Without a pull requests line they behave as before.

Verification

  • node scripts/validate-plugins.mjs, node scripts/generate-pstack-harness-trees.mjs --check, and node scripts/check-pstack-docs.mjs pass.
  • I gave the new Readiness text to one agent per case, with a stub gh that logs its arguments. A draft line produced gh pr create --draft. A ready line, and a "ready for review" request over a draft line, produced no --draft. The current text ignored a draft line.

poteto-mode opened every PR ready. A `pull requests: draft` line in
the pstack-models rule now makes it open drafts, and a request in the
task overrides the line for that task. A missing line keeps the old
behavior.

/setup-pstack asks for the value and writes the line. Babysit passes
--allow-draft to watch-pr for a draft, and a playbook that merges marks
a draft ready right before the merge.
mstephenholl added a commit to mstephenholl/pstack-claude-codex that referenced this pull request Nov 13, 2026
## Why

You can now choose whether a poteto-mode run ends with a draft PR or a
ready one. The Opening a PR playbook opened every PR ready, and no
setting changed that. A `pull requests: draft` line in
`~/.agents/pstack-models.md` now makes poteto-mode open drafts.

## What changed

- The Readiness section of `opening-a-pr.md` reads the `pull requests`
line. A request in the task wins over the line, and a missing line means
ready. `multi-phase-plan`, `babysit`, and `shipping` follow Readiness.
- `pstack configure` takes `--pull-requests ready|draft`, writes the
line, and keeps it on a rerun instead of dropping it as a retired line.
`setup-pstack` asks for the value.

## Scope

- Ready stays the default, so nothing changes until someone sets
`draft`.
- The playbook text matches cursor#1228, so a later upstream
sync merges it without conflict.
- The text does not name Origin's draft flag, because I could not
confirm it. It sends the agent to `origin pr create --help` instead.

## Tradeoffs

- The setting is a line in the models file, not a new file. Every skill
already reads the models file, and `foreign seats` is already a line
there that is not a role.

## Blast Radius

Runs that open, babysit, or ship PRs read the new text, and without a
`pull requests` line they behave as before. A rerun of `pstack
configure` adds `pull requests: ready` to an existing models file.

## Verification

- `python3 -m unittest discover -s pstack/port/tests` passes 267 tests,
including three new `configure` tests. `check.py` reports 0 problems.
- I gave the new Readiness text to one Sonnet agent per case, with a
stub `gh` that logs its arguments. A `draft` line produced `gh pr create
--draft`. A `ready` line, and a "ready for review" request over a
`draft` line, produced no `--draft`. The old text ignored a `draft`
line.
- `git merge-tree` of this branch with the upstream branch shows no
conflict in the four playbooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant