Skip to content

Update nubank spei code - #191

Merged
gmorales96 merged 2 commits into
mainfrom
update-nubank-spei-code
Aug 5, 2026
Merged

Update nubank spei code#191
gmorales96 merged 2 commits into
mainfrom
update-nubank-spei-code

Conversation

@gmorales96

@gmorales96 gmorales96 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

https://github.com/cuenca-mx/legales/issues/169

Summary by CodeRabbit

  • Bug Fixes

    • Corrected NUBANK’s bank identifier and display name in CLABE validation and lookup results.
  • Release

    • Updated the package version to 2.1.11.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d3254e28-183f-4556-97c9-0ac4f256720a

📥 Commits

Reviewing files that changed from the base of the PR and between 4af46c6 and 922cd5b.

📒 Files selected for processing (2)
  • clabe/banks.py
  • clabe/version.py

Walkthrough

The NUBANK bank mapping now uses code 40638 and the name NUBANK. The package version changes from 2.1.10 to 2.1.11.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the Nubank SPEI code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-nubank-spei-code

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4af46c6) to head (922cd5b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           84        84           
=========================================
  Hits            84        84           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clabe/banks.py 100.00% <ø> (ø)
clabe/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af46c6...922cd5b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmorales96
gmorales96 merged commit bf89eca into main Aug 5, 2026
15 checks passed
@gmorales96
gmorales96 deleted the update-nubank-spei-code branch August 5, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants