Handle the retry_total_tests configuration option in the runner - #344
Open
brasmusson wants to merge 1 commit into
Open
Handle the retry_total_tests configuration option in the runner#344brasmusson wants to merge 1 commit into
brasmusson wants to merge 1 commit into
Conversation
* The retry filter both take into account the retry_attempts and the retry_total_tests configuration options, therefore the runner will have to do the same when calculating the will_be_retried field in the test_case_finished envelopes.
5 tasks
luke-hill
reviewed
Aug 30, 2026
luke-hill
left a comment
luke-hill
left a comment
Contributor
There was a problem hiding this comment.
Great work finding this out
| private :event_bus, :running_test_case, :running_test_step, :id_generator | ||
|
|
||
| def initialize(event_bus, id_generator = Cucumber::Messages::Helpers::IdGenerator::UUID.new, backtrace_filter = nil, max_attempts = 1) | ||
| def initialize(event_bus, id_generator = Cucumber::Messages::Helpers::IdGenerator::UUID.new, backtrace_filter = nil, max_attempts = 1, max_total_retried_tests = Float::INFINITY) |
Contributor
There was a problem hiding this comment.
can this lean on the config option rather than the verbose value. As this value is a default for the config option (Question btw)
Contributor
There was a problem hiding this comment.
Ah I see now, this "will" lean on the config value specified.
luke-hill
approved these changes
Sep 1, 2026
Contributor
|
@brasmusson i'm going to be off for a week now. Can you just ensure that appropriate changelogs are written. But feel free to merge both as/when appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The retry filter both take into account the retry_attempts and the retry_total_tests configuration options, therefore the runner will have to do the same when calculating the will_be_retried field in the test_case_finished envelopes.
Now that the runner does not take the retry_total_tests configuration option, test_case_finished envelopes can state that the test case will be retried, but the retry filter will not retry the test case. This confuses that HTML formatter which only displays result for test cases which has a test case finished envelope with will_be_retried=false (that is the final try for that test case).
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Note to other contributors
If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses