Skip to content

Refactor/tests and support matrix #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-hill merged 2 commits into from
Aug 13, 2026
Merged

Refactor/tests and support matrix #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7fcb87
Updating testing matrix and supported platforms
luke-hill Aug 13, 2026
76816c8
Autofix a couple of spec layout cops
luke-hill Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-ruby.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
ruby: ['3.2', '3.3', '3.4', '3.5']
ruby: ['3.2', '3.3', '3.4', '4.0']
include:
- os: ubuntu-latest
ruby: jruby
Expand Down
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ or install the gem directly:

### Supported platforms

- Ruby 3.3
- Ruby 3.2
- Ruby 3.1
- Ruby 3.0
- JRuby 9.4 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/main/docs/jruby-limitations.md))
Supported Platforms are detailed in the [cucumber-ruby repository](https://github.com/cucumber/cucumber-ruby#supported-platforms).

## Usage

Expand Down
1 change: 0 additions & 1 deletion spec/cucumber/core/test/result/skipped_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# frozen_string_literal: true

require 'cucumber/core/test/result'
Expand Down
4 changes: 2 additions & 2 deletions spec/cucumber/core/test/result/summary_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
require 'support/duration_matcher'

describe Cucumber::Core::Test::Result::Summary do
subject(:summary) { described_class.new }
subject(:summary) { described_class.new }

let(:failed) { Cucumber::Core::Test::Result::Failed.new(Cucumber::Core::Test::Result::Duration.new(10), exception) }
let(:passed) { Cucumber::Core::Test::Result::Passed.new(Cucumber::Core::Test::Result::Duration.new(11)) }
let(:skipped) { Cucumber::Core::Test:: Result::Skipped.new }
let(:skipped) { Cucumber::Core::Test::Result::Skipped.new }
let(:unknown) { Cucumber::Core::Test::Result::Unknown.new }
let(:pending) { Cucumber::Core::Test::Result::Pending.new }
let(:undefined) { Cucumber::Core::Test::Result::Undefined.new }
Expand Down