Repository navigation
refactor: name the sample files and the mesh ingress docs Ascender - #59
Merged
cigamit merged 1 commit intoSep 17, 2026
Merged
Conversation
The first thing the README tells a reader to run is `kubectl apply -f awx-demo.yml`, and that file creates an AWX named awx-demo. Every other surface a new deployment touches is Ascender now, so the sample that introduces the operator should be too. awx-demo.yml becomes ascender-demo.yml and declares an Ascender in ascender.ansible.com, which is what a new deployment should be. awxmeshingress-demo.yml follows, and the README points at both. The mesh ingress documentation was left half converted: ctrliq#50 moved the apiVersion and kind rows of its reference table to Ascender but not the AWXMeshIngressSpec, AWXMeshIngressStatus and AWXMeshIngressList rows beside them, nor the headings those rows link to. All twenty six move together, anchors included, and every in page link still resolves. docs/awx-demo.svg goes. It is an 844 kilobyte terminal recording that nothing references, showing an install of awx-operator.yaml producing a pod named awx-operator-7dbf9db9d7-z62pm: a workflow that cannot happen any more. It stays in the history if anyone wants it back. A comment in the installer defaults offered awx-demo.example.com as an example hostname, which now matches the sample it refers to.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cigamit
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first thing the README tells a reader to run is
kubectl apply -f awx-demo.yml, and that file creates anAWXnamedawx-demo. Everything else a new deployment touches is Ascender now, so the sample that introduces the operator should be too.The samples
awx-demo.yml→ascender-demo.yml, declaring anAscenderinascender.ansible.comawxmeshingress-demo.yml→ascendermeshingress-demo.yml, anAscenderMeshIngresspointing atascender-demoawx-demo.example.comnow matches the sample it refers toThe mesh ingress docs were left half converted
#50 moved the
apiVersionandkindrows of the reference table to Ascender, but not theAWXMeshIngressSpec,AWXMeshIngressStatusandAWXMeshIngressListrows beside them, nor the headings those rows link to. A table sayingkind: AscenderMeshIngressand then linking toAWXMeshIngressSpecis worse than either end of it.All 26 occurrences move together, anchors included:
#awxmeshingressspecand friends would otherwise have pointed at headings that no longer exist. Checked afterwards that every in-page link still resolves to a heading, andmkdocs build --strictpasses.One deletion
docs/awx-demo.svg, an 844 KB terminal recording that nothing references. It shows an install ofawx-operator.yamlproducing a pod namedawx-operator-7dbf9db9d7-z62pm, which cannot happen any more after #54. It stays in git history if anyone wants it back.What is deliberately untouched
The
awx.ansible.comCRDs, their kustomization entries and the CSV: that group is served on purpose so existing deployments keep working, and the sample moving to Ascender does not change that.