Skip to content

feat: upgrade min sdk from 16 to 24 - #387

Merged
andrii-bodnar merged 2 commits into
masterfrom
feat/min-sdk-24
Sep 16, 2026
Merged

andrii-bodnar merged 2 commits into
masterfrom
feat/min-sdk-24

Conversation

@MykhailoNester

Copy link
Copy Markdown
Collaborator

No description provided.

@MykhailoNester MykhailoNester self-assigned this Sep 16, 2026
@MykhailoNester MykhailoNester added the enhancement New feature or request label Sep 16, 2026
@andrii-bodnar andrii-bodnar changed the title feat: upgrade min sdk from 16 to 24; feat: upgrade min sdk from 16 to 24 Sep 16, 2026
@andrii-bodnar
andrii-bodnar requested a lite review from Copilot September 16, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the public Locale.toLanguageTagCompat() extension breaks source and binary API compatibility for SDK consumers.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR raises the minimum Android SDK from 16 to 24 and removes obsolete compatibility code.

Changes:

  • Centralizes API 24 requirements across modules and examples.
  • Removes multidex configuration and legacy API guards.
  • Updates documentation, locale handling, and tests.
File summaries
File Summary
website/docs/installation.md Documents Android API 24 minimum.
website/docs/guides/platforms-support.md Updates Fire OS support guidance.
website/docs/faq.md Removes obsolete pre-API-24 locale guidance.
gradle/libs.versions.toml Removes the multidex dependency.
example/build.gradle Uses the centralized minimum SDK.
example-info/build.gradle Uses the centralized minimum SDK.
crowdin/src/test/java/com/crowdin/platform/LocaleResolutionEndToEndTest.kt Updates locale test setup.
crowdin/src/test/java/com/crowdin/platform/LocaleMatchingTest.kt Updates locale test setup.
crowdin/src/test/java/com/crowdin/platform/LocaleKeysTest.kt Updates locale test setup.
crowdin/src/test/java/com/crowdin/platform/CrowdinConfigTest.kt Removes obsolete API-level assertions.
crowdin/src/main/java/com/crowdin/platform/util/Extensions.kt Removes compatibility branches; deleting public toLanguageTagCompat() causes a critical API break.
crowdin/src/main/java/com/crowdin/platform/transformer/ToolbarTransformer.kt Removes obsolete API annotations.
crowdin/src/main/java/com/crowdin/platform/realtimeupdate/EchoWebSocketListener.kt Enables plural handling unconditionally.
crowdin/src/main/java/com/crowdin/platform/data/remote/StringDataRemoteRepository.kt Uses direct language-tag conversion.
crowdin/src/main/java/com/crowdin/platform/CrowdinResources.kt Simplifies resource and plural handling.
crowdin/src/main/java/com/crowdin/platform/CrowdinConfig.kt Removes Compose API gating.
crowdin/src/main/java/com/crowdin/platform/compose/ComposeStringRepository.kt Removes the legacy plural fallback.
crowdin/src/main/java/androidx/appcompat/app/BaseContextWrappingDelegate.kt Removes the obsolete night-mode guard.
crowdin/lint.xml Removes legacy API warning configuration.
crowdin/build.gradle Removes multidex configuration.
crowdin-controls/src/main/res/layout/custom_toast_layout.xml Removes the redundant margin attribute.
crowdin-controls/src/main/java/com/crowdin/crowdin_controls/OverlayActivityContract.kt Removes the obsolete overlay API guard.
crowdin-controls/src/main/java/com/crowdin/crowdin_controls/CrowdinWidgetService.kt Uses direct locale configuration.
crowdin-controls/src/main/java/com/crowdin/crowdin_controls/CrowdinControlUtil.kt Removes the obsolete overlay permission guard.
crowdin-controls/build.gradle Removes multidex configuration.
build.gradle Raises the centralized minimum SDK to 24.
Review details
  • Files reviewed: 25/26 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crowdin/src/main/java/com/crowdin/platform/util/Extensions.kt
@andrii-bodnar
andrii-bodnar merged commit d7c172a into master Sep 16, 2026
3 checks passed
@andrii-bodnar
andrii-bodnar deleted the feat/min-sdk-24 branch September 16, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants