Conversation
nkzk
force-pushed
the
feat-project-closed-networks
branch
2 times, most recently
from
October 1, 2026 11:13
7b34bc4 to
450403a
Compare
Signed-off-by: Nikita Z <nkzk95@gmail.com>
Bind-mounting the local registry directory into the registry container relies on the CLI's filesystem being visible to the Docker daemon. That breaks when Crossplane itself runs inside a container, since the mount path only exists in the CLI's own filesystem, not the daemon's. Signed-off-by: Nikita Z <nkzk95@gmail.com>
Signed-off-by: Nikita Z <nkzk95@gmail.com>
Signed-off-by: Nikita Z <nkzk95@gmail.com>
Signed-off-by: Nikita Z <nkzk95@gmail.com>
Signed-off-by: Nikita Z <nkzk95@gmail.com>
nkzk
force-pushed
the
feat-project-closed-networks
branch
from
October 1, 2026 11:30
450403a to
e272f26
Compare
Signed-off-by: Nikita Z <nkzk95@gmail.com>
Contributor
Author
|
Before review, I want to refactor this again so that the registry-storage works like before by default, and add a config flag for the docker-volume method. I think that will be cleaner and better. |
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
nkzk
force-pushed
the
feat-project-closed-networks
branch
from
October 2, 2026 14:56
d87dd05 to
4d44ebc
Compare
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
tenstad
reviewed
Oct 2, 2026
nkzk
force-pushed
the
feat-project-closed-networks
branch
from
October 2, 2026 15:17
5b4ba76 to
93f6845
Compare
tenstad
reviewed
Oct 2, 2026
…o select stoarge-type the bindmount implementation ensures that we keep old behavior, and the volume implementation is for DinD support Signed-off-by: Nikita Z <nkzk95@gmail.com>
nkzk
force-pushed
the
feat-project-closed-networks
branch
from
October 2, 2026 15:20
f2657dd to
2b1280e
Compare
Signed-off-by: Nikita Z <nkzk95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds support for running
crossplane projectin devcontainers and closed company networks with the following changes:Add configuration options for KinD in
crossplane-project.yaml.internalKinD kubeconfig.Example crossplane-project file
Support registry data sideloading when running crossplane project in Docker-in-Docker
When running
crossplane projectin a container, bind-mounting the CLI’s local registry directory into the registry container mounts an empty host path, leaving the registry without its certificates and package data.This happens because the generated files are only in the container where the command was ran, and not on the host.
I added a storage interface where the bind-mount implementation ensures we keep old behavior, and a config-flag to use a volume-implementation. This required some refactoring of the code, for example where certs are created.
Fixes #313
With these changes, a user in a closed company network and devcontainer can run
crossplane projectwith the following files and command:./crossplane-project.yaml
./kind-config.yaml
./image-configs.yaml
I have:
./nix.sh flake checkto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.