feat: Add portIdRef and portIdSelector support to RouterInterfaceV2#172
Merged
Conversation
Avatos
approved these changes
Jun 19, 2026
Avatos
left a comment
Avatos
left a comment
Collaborator
There was a problem hiding this comment.
Hey, thank you for your contribution, lgtm!
Collaborator
|
@titigmr, could you please review the failed check and commit any pending changes after running |
Signed-off-by: titigmr <thierry.gmr@outlook.fr>
Avatos
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add cross-reference for portIdRef and portIdSelector to RouterInterfaceV2
Fixes #171
I have:
make submodules; make reviewable testto ensure this PR is ready for review.How has this code been tested
In progress