Repository navigation
Fix 1985 - #1998
Merged
Merged
Fix 1985#1998
Conversation
…--parallel) hatch_build.py built flatc with `cmake --build . --target flatc` and no --parallel, so on one core: about 4 minutes on every wheel build, editable install and `just test-*` run. It now passes `--parallel <os.cpu_count()>`. An explicit CMAKE_BUILD_PARALLEL_LEVEL in the environment still wins: then --parallel is given without a count, and cmake reads the variable. The build log names the job count, so a CI log shows which was used. Same change as zlmdb 9e74456 (crossbario#174). This is the parallel-build point of crossbario#1985 only. The input stamp, skipping an unchanged flatc, and AUTOBAHN_FORCE_FLATC_BUILD stay open. Measured on asgard1 (same configure arguments, out-of-tree build of deps/flatbuffers, flatc 25.12.19): serial 237 s, 16 jobs 25 s. A full `uv build --wheel` (cpy314, CMAKE_BUILD_PARALLEL_LEVEL=16) took 34 s and the wheel contains autobahn/_flatc/bin/flatc. ruff check and just check-typing cpy314 pass. No red/green pair: build speed only, no behaviour change to test. Expected CI result: GREEN - all jobs, with the flatc step of the wheel jobs faster; every wheel still bundles flatc. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1985