Repository navigation
Conversation
…st/asset name guard)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. No tag, no release, no release draft. Publishing needs Gustavo's OK.
Contents
package.jsonandpackage-lock.json. Both desktop editions (KeepMind and Corp) inherit it. The Corp server (corp/lib.mjsCORP_VERSION0.8.0) and the standalone MCP (tools/package.json0.1.1) are versioned separately and stay unchanged.CHANGELOG.md:[0.2.7] - unreleased. It takes the previous Unreleased items, adds the Fixed entries and keeps an empty[Unreleased].2869b3e(fix: keep Windows installer URLs consistent with published assets #16, "align Windows installer names with update manifests") is an ancestor of this branch, and both configs define an explicitartifactName(mac/nsis/linux). The 0.2.6 bug:latest.ymlpointed toKeepMind-Setup-0.2.6.exebut the asset isKeepMind.Setup.0.2.6.exe. Corp had the same problem on mac (KeepMind-Corp-0.2.6-arm64.dmgvsKeepMind.Corp-0.2.6-arm64.dmg) and on Windows.tests/release-artifact-names.test.tsnow covers both editions × mac (dmg, zip; arm64/x64/universal) × Windows (nsis). It expands theartifactNamewith app-builder-lib's real macro expander and fails if the name isn't GitHub-safe (computeSafeArtifactNameIfNeededmust return null) or if there's no explicitartifactName.scripts/check-update-manifests.mjs <dist>(npm run check:update-manifests) runs after the build. For everylatest*.ymlit checks that eachfiles[].url/pathexists with exactly that name, with the same size and sha512, and a safe name.tests/check-update-manifests.test.tscovers a good case, the 0.2.6 bug reproduced, and wrong size or sha.packaged-*-smoke.mjs,updater-download.test.ts).Local validation
derived-learnings,sync) are environmental: no Electron binary and noout/locally. They fail the same way on main.check-release-gatesreports no errors.Packaging validation without publishing: separate test branch
test/0.2.7-package-dryrun-1411, with its own workflowpackage-dryrun-027.yml(prep + the Corp signing fix from #25). It runselectron-builder --publish neveron macos-latest and windows-2022 for both editions, thencheck-update-manifests. Onlylatest*.ymland the file list are uploaded, not the installers.Before publishing: merge #25 (Corp mac signature) and #26 (macOS 15 docs) if approved, set the date in the changelog, and decide whether Corp keeps publishing to
criptogus/keepmind-corp.