Repository navigation
docs: name the assistant Ask Crewlet - #53
Merged
Merged
Conversation
The engine's in-dashboard assistant is now named Ask Crewlet. Rename it in the API types' doc comments, and so in the CRD descriptions, the chart's CRDs and the generated API reference, and in the guides, the concepts and CONTRIBUTING. The CEL message for an enabled assistant without llm names it too. Field names, JSON keys and every other contract stay as they were. Signed-off-by: pinotelio <ahmadreza.mollapour@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine's in-dashboard assistant is now named Ask Crewlet. This PR renames it wherever the operator names it to people. It replaces "Dashboard Assistant" and "the assistant".
What changes
kubectl explain): the doc comments onspec.assistantand its deep work inapi/v1alpha1/*_types.go. The CRDs, the chart's CRDs anddocs/reference/api.mdwere regenerated withmake manifests generate chart api-docs, the same setverify-generatedchecks, so nothing generated was edited by hand.spec.assistantwithoutllmnow reads "Ask Crewlet, when enabled, needs llm: name the model provider it runs on, one whose webTools is Denied". The test constantmsgEnabledNeedsLLMis updated to match.guides/cli-agents.md,guides/exposure.md,concepts/company-document.md,concepts/runtime.mdand CONTRIBUTING.What stays
spec.assistant*paths, example resource names (assistant,assistant-deep), the sandbox path, and the engine config mirror.Note
The heading "A provider for Ask Crewlet" in
docs/guides/cli-agents.mdchanges its anchor from#a-provider-for-the-dashboard-assistantto#a-provider-for-ask-crewlet. I updated the one link to it inside this repo. No other Crewlet repo links to the old anchor.Tests
go build ./...andgo vetpass forapi/...,internal/...andtest/crd/..., and gofmt is clean.TestCompanyAssistantValidationandTestCompanyAssistantDeepWorkValidationpass, including the new message.Companion PRs: crewlet/uilet#160, and the engine rename (in progress).