Repository navigation
Respect configured -march when building libargon2 - #1247
Merged
Merged
Conversation
crazywhalecc
added
need-test
|
StaticPHP Test Bot Detected: Extensions: none | Libraries: |
crazywhalecc
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argon2's Makefile defaults
OPTTARGETtonative, which can compile host-specific instructions into redistributable binaries. Use the last-marchin the library's configured CFLAGS. If none is set, passOPTTARGET=noneto select Argon2's portable implementation. Apply the same target to clean, build, and install.This addresses the Argon2 SIGILL reported in php/frankenphp#2684. The same fix is already on
feat/pgo-v3.Verification
php -l src/Package/Library/libargon2.phpOPTTARGET=noneand ran its test suite successfully on aarch64.-march=armv8-a/OPTTARGET=armv8-aand ran the test suite successfully.-marchvalues, multiple flags, and the unset fallback.