frankenphp: build the Mercure hub with its 0.x compatibility tags - #1240
Merged
Merged
Conversation
Mercure 1.0 gates its 0.x behaviors (legacy mercure claim, topic= selectors) behind the deprecated_topic and deprecated_claim build tags, only honored when the Caddyfile sets protocol_version_compatibility 8. FrankenPHP ships them in its Docker images and CI builds so users can migrate progressively; static binaries get their tags from here. Go ignores unknown tags, so FrankenPHP versions still on Mercure 0.x build unchanged.
henderkes
approved these changes
Sep 8, 2026
Collaborator
|
For this to take any effect, we need to switch to spc v3 which is still open because I don't have a mac to fix x86. |
crazywhalecc
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mercure 1.0 (https://github.com/dunglas/mercure/releases/tag/v1.0.0-alpha.3) gates its 0.x behaviors behind two build tags,
deprecated_topicanddeprecated_claim, and only honors them when the Caddyfile setsprotocol_version_compatibility 8. Without the tags, a hub in compatibility mode rejects 0.x tokens andtopic=selectors outright.FrankenPHP is adopting the 1.0 hub in php/frankenphp#2611 and ships both tags in its Docker images and CI builds, like the official Mercure binaries, so users can migrate progressively. Static binaries take their
-tagslist from here, andGOFLAGScannot add to a-tagsgiven on the command line, hence this change.Go ignores unknown build tags, so FrankenPHP versions still on Mercure 0.24 build unchanged.