feat: render dependent noexcept specifications as noexcept(see-below)#1180
Open
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Open
feat: render dependent noexcept specifications as noexcept(see-below)#1180gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Conversation
✨ Highlights
🧾 Changes by Scope
🔝 Top Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1180 +/- ##
===========================================
+ Coverage 78.85% 81.89% +3.03%
===========================================
Files 308 33 -275
Lines 32157 2983 -29174
Branches 6456 691 -5765
===========================================
- Hits 25359 2443 -22916
+ Misses 4436 373 -4063
+ Partials 2362 167 -2195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e52e6d to
7ee2a4e
Compare
|
An automated preview of the documentation is available at https://1180.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-04-23 08:24:03 UTC |
MrDocs used to render the full `noexcept` operand inline, so a
declaration like
void swap(reference, reference) noexcept(
std::is_nothrow_move_constructible<value_t>::value &&
std::is_nothrow_move_assignable<value_t>::value &&
std::is_nothrow_move_constructible<json_value>::value &&
std::is_nothrow_move_assignable<json_value>::value);
buried the `noexcept` condition in a mostly-unreadable slop.
This replaces dependent operands with an italic "see-below" placeholder
in the declaration, and moves the actual condition to a dedicated
"noexcept Specification" section of the exposition:
void swap(reference, reference) noexcept(see-below);
=== noexcept Specification
noexcept when `...long condition...`.
The section is intentionally separate from the existing "Exceptions"
section, which continues to cover `@throws` documentation.
Closes issue cppalliance#1103.
7ee2a4e to
4fa1508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MrDocs used to render the full
noexceptoperand inline, so a declaration likeburied the
noexceptcondition in a mostly-unreadable slop.This replaces dependent operands with an italic "see-below" placeholder in the declaration, and moves the actual condition to a dedicated "noexcept Specification" section of the exposition:
The section is intentionally separate from the existing "Exceptions" section, which continues to cover
@throwsdocumentation.Closes issue #1103.