fix: refactor for unsupported static binary platforms#356
Conversation
previous builds for unsupported platforms issued a bunch of warnings because of unused code. This refactors the clang-tools-manager/src/downloader/static_dist.rs module to only compile code that is actually used per the compile target.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 92.83% 92.84%
=======================================
Files 23 23
Lines 3461 3464 +3
=======================================
+ Hits 3213 3216 +3
Misses 248 248 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
and reduce the frequency of the stale issues check
|
Warning Review limit reached
More reviews will be available in 46 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR consolidates version seeding logic across six CI/CD workflows into a new reusable workflow, refactors all workflows to use dynamic artifact naming, and restructures the Rust downloader with platform-conditional compilation modules. A minor schedule update to the stale issues workflow is also included. ChangesVersion Seeding Refactor and Platform Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Previous builds for unsupported platforms issued a bunch of warnings because of unused code.
This refactors the clang-tools-manager/src/downloader/static_dist.rs module to only compile code that is actually used per the compile target.
Summary by CodeRabbit
New Features
Chores