fix: CodeRabbit auto-fixes for PR #615#616
Conversation
Fixed 5 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
| ## Getting notified about the ranking | ||
|
|
||
| A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards) section). | ||
| A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.fi/cow-protocol/reference/core/auctions/competition-rules) section). |
There was a problem hiding this comment.
More succinct way of saying this:
The driver's notify endpoint does something useful: once all solutions are in and ranked, it tells every participating solver where they placed. See the competition rules for how ranking works.
|
|
||
| ### Are there any prerequisites in the shadow environment that we must meet before being allowed to join staging? | ||
| No, there are no prerequisites (other than KYC if joining the CoW DAO bonding pool) but it is recommended that the solver manages to submit and win solutions on shadow before staging. | ||
| No, there are no prerequisites (other than KYC if joining the CoW DAO bonding pool) but it is recommended that the solver manages to submit and win solutions on shadow before staging. No newline at end of file |
There was a problem hiding this comment.
better way of saying this: No prerequisites apply, though solvers are encouraged to successfully submit and win solutions on shadow before moving to staging. Note: joining the CoW DAO bonding pool requires KYC.
1 participant
This stacked PR contains CodeRabbit auto-fixes for #615.
Files modified:
CONTRIBUTING.mddocs/cow-protocol/tutorials/cow-amm-deployer.mdxdocs/cow-protocol/tutorials/solvers/evaluate.mddocs/cow-protocol/tutorials/solvers/local_test.mddocs/cow-protocol/tutorials/solvers/onboard.md