Open
Conversation
This struct was removed quite some time ago.
|
Bencher Report| Branch | cotproject |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.40 ms(+5.37%)Baseline: 6.08 ms | 7.39 ms (86.64%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.14 ms(+7.71%)Baseline: 1.06 ms | 1.26 ms (90.36%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.07 ms(+9.76%)Baseline: 0.98 ms | 1.15 ms (92.79%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.03 ms(+10.16%)Baseline: 0.94 ms | 1.12 ms (92.38%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 16.96 ms(-4.06%)Baseline: 17.68 ms | 21.08 ms (80.45%) |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a stale CotProject reference from the cot-macros UI test fixture so the macro diagnostics no longer mention a struct that has been removed from the cot API.
Changes:
- Update the UI test source to use
cot::Projectinstead ofCotProjectin the annotatedmainsignature. - Update the corresponding trybuild
.stderrexpected output to match the new signature text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cot-macros/tests/ui/attr_main_args.rs | Updates the UI test’s main return type text to avoid CotProject. |
| cot-macros/tests/ui/attr_main_args.stderr | Updates expected diagnostic output to match the revised test source line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| #[cot::main] | |||
| async fn main(arg: i32) -> cot::Result<CotProject> { | |||
| async fn main(arg: i32) -> cot::Result<cot::Project> { | |||
| --> tests/ui/attr_main_args.rs:2:15 | ||
| | | ||
| 2 | async fn main(arg: i32) -> cot::Result<CotProject> { | ||
| 2 | async fn main(arg: i32) -> cot::Result<cot::Project> { |
Comment on lines
1
to
+2
| #[cot::main] | ||
| async fn main(arg: i32) -> cot::Result<CotProject> { | ||
| async fn main(arg: i32) -> cot::Result<cot::Project> { |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This struct was removed quite some time ago.
Type of change