Open
Conversation
|
Bencher Report| Branch | elijah/query-macro-docs |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.54 ms(+7.53%)Baseline: 6.08 ms | 7.39 ms (88.41%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.17 ms(+10.35%)Baseline: 1.06 ms | 1.26 ms (92.57%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.08 ms(+10.90%)Baseline: 0.98 ms | 1.15 ms (93.76%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.04 ms(+10.99%)Baseline: 0.94 ms | 1.12 ms (93.07%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17.43 ms(-1.42%)Baseline: 17.68 ms | 21.08 ms (82.67%) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
seqre
requested changes
Apr 9, 2026
seqre
requested changes
Apr 13, 2026
ElijahAhianyo
force-pushed
the
elijah/query-macro-docs
branch
from
cdea9fd to
377b744
Compare
m4tx
reviewed
Apr 20, 2026
Comment on lines
-37
to
-40
| if let Some(tokens) = expr.as_tokens() { | ||
| return tokens; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
What's the reasoning behind removing this?
m4tx
reviewed
Apr 20, 2026
Comment on lines
+359
to
+361
| /// [`Query`]: query/struct.Query.html | ||
| /// [`Query::get`]: query/Struct.Query.html#method.get | ||
| /// [`Query::all`]: query/Struct.Query.html#method.all |
Member
There was a problem hiding this comment.
We can always move these docs into the main crate instead to avoid these hardcoded links. Does that make sense?
Contributor
Author
There was a problem hiding this comment.
Not sure I get this. Where in the main crate will this be moved?
The model (and other) macro docs live in the cot-macro crate and are then referenced in the main crate. Does this move from that idea?
m4tx
approved these changes
Apr 20, 2026
Member
m4tx
left a comment
m4tx
left a comment
There was a problem hiding this comment.
LGTM, but please have a look at my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation for
query!macroType of change
Checklist
just test-all)just clippy)cargo fmt)