Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
ICEY16360
force-pushed
the
feat/bulk-restore-permanent-memories
branch
from
October 13, 2026 13:24
b65279d to
2a41742
Compare
…676) The Memories bulk bar could archive or delete a selection but not bring rows back, even though bulk_update_memory_status already accepts active and permanent and only bumps the epoch for rows whose status actually changes. Archived entries could be restored one at a time through the detail Status dropdown, but not in bulk. - MemoryBrowser: Restore and Make permanent buttons next to Archive, with confirm dialogs mirroring the Archive one - db_mutations: a mixed-selection test asserting only the rows that actually transition change status, only their project paths bump the epoch, and a restore queues no memory mutations - docs: the bulk-select line now lists restore and make permanent
ICEY16360
force-pushed
the
feat/bulk-restore-permanent-memories
branch
from
October 13, 2026 13:35
2a41742 to
effa624
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved issue: #676
What
Adds Restore and Make permanent to the Memories bulk-action bar, so a selection can be brought back from archived (or lifted to permanent) in one command. The backend already supports both:
bulk_update_memory_statusaccepts any status, treats a change intoactive/permanentas a restore for epoch-bump purposes, and only bumps for rows whose status actually changes.Changes
packages/dashboard/src/components/MemoryBrowser/MemoryBrowser.tsx:handleBulkRestore/handleBulkPermanentmirroringhandleBulkArchive(confirm →bulkUpdateMemoryStatus→ clear selection → refetch), plus Restore and Make permanent buttons next to Archive. Confirm dialogs mirror the Archive one, including the singular/plural template.packages/dashboard/src-tauri/tests/db_mutations.rs:bulk_restore_mixed_selection_changes_and_bumps_only_actually_changed_rows— a mixed selection (archived→active and permanent→active that change, active→active no-ops, including one project path with no changes at all) asserts only the transitioning rows change, only their paths bump the epoch, and a restore queues no memory mutations.packages/docs/src/content/docs/reference/dashboard.md: the bulk-select line now lists restore and make permanent.No production Rust change — the approved shape is frontend plus a test of the existing command.
Harness coverage (required)
bulk_update_memory_status's no-op guard and epoch semantics (no production Rust change)Summary by cubic
Adds Restore and Make permanent to the Memories bulk-action bar, so a selection can be brought back from archived or lifted to permanent in one command, alongside the existing Archive and Delete.
bulk_update_memory_status; only frontend, tests, and docs change.Written for commit effa624. Summary will update on new commits.

Confidence Score: 5/5
The PR appears safe to merge, with no outstanding findings.Summary
Adds Restore and Make permanent to the Memories bulk-action bar.
No new actionable issues were found. The previous selection warning finding is fixed. Tests were inspected but not run.
Reviews (3) · Last reviewed commit: "feat(dashboard): bulk restore and make p..." · Reviewed by Greptile