chore(dicom-codec): raise jpeg-lossless-decoder-js to 2.2.1 - #96
chore(dicom-codec): raise jpeg-lossless-decoder-js to 2.2.1#96wayfarer3130 wants to merge 1 commit into
Conversation
@cornerstonejs/jpeg-lossless-decoder-js 2.2.1 restores the author metadata that npm dropped from the published package: the manifest declared the author as an array, which npm does not accept, so 2.2.0 carried no attribution at all. 2.2.1 is also the first version that CI published, so it carries a provenance attestation, and 2.2.0 does not. The decoded pixels cannot change. release/cjs/lossless.cjs and release/cjs/lossless.cjs.map are byte-identical between 2.2.0 and 2.2.1, and only README.md and package.json differ between the two tarballs. Verified: the 102 dicom-codec tests pass, 7 skipped, including both byte-exact JPEG Lossless comparisons. pnpm-workspace.yaml needs no change. Its minimumReleaseAgeExclude entry names the package and no version, so a new release of the package installs without an edit here. A version-pinned entry, which is what pnpm writes by itself, would have failed this install. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe DICOM codec package updates ChangesDICOM codec dependency
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This dependency-only update has no identified runtime or integration risk and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will regress 2 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
What changes
@cornerstonejs/jpeg-lossless-decoder-jsmoves from^2.2.0to^2.2.1.Two files change, and six lines.
2.2.1 restores the author metadata that npm dropped from the published package:
the manifest declared the author as an array, which npm does not accept, so
2.2.0 carried no attribution at all. 2.2.1 is also the first version that CI
published, so it carries a provenance attestation and 2.2.0 does not.
The decoded pixels cannot change
release/cjs/lossless.cjsandrelease/cjs/lossless.cjs.maparebyte-identical between 2.2.0 and 2.2.1. Only
README.mdandpackage.jsondiffer between the two tarballs:
The 102 dicom-codec tests pass, 7 skipped, and that count includes both
byte-exact JPEG Lossless comparisons. The
.70SV1 fixture is the regressioncase for the end-of-scan fix, and it fails on any decoder without the fix.
This pull request is also a CodSpeed control
A benchmark that this pull request flags is noise, because the executed code
does not change. That makes this a useful measurement of the reports
themselves.
mainholds a real baseline for the first time in a while. The merge of #94(
acc43f1) did not seed one:build (big-endian)failed withwgetexitcode 4, a transient network error while it fetched cmake 3.17.4, and one
non-success among the nine build jobs makes
bench.yml's gate skip the bench —while the Bench run still reports
success. Re-running that job and thendispatching
bench.ymlonmainseeded the baseline (run34608677463,codspeed-benchsuccess).pnpm-workspace.yamlneeds no change here, so the gate benchesdicom-codecalone rather than a full sweep. Its
minimumReleaseAgeExcludeentry names thepackage and no version, so a new release of the package installs without an
edit. A version-pinned entry, which is what pnpm writes by itself, would have
failed this install.
🤖 Generated with Claude Code
Summary by CodeRabbit