ci: bound every pr-checks job with timeout-minutes - #92
Conversation
`build (big-endian)` wedged on PR #70 and sat in_progress for over 80 minutes while its nine sibling matrix legs finished in 58-239s. Nothing bounded it, so it was headed for GitHub's 6-hour default. fail-fast is off for that matrix by design, so one wedged leg keeps the entire run -- and test, dist-size, browser-smoke and codspeed-walltime, which all need it -- pending that whole time. bench.yml also waits on this workflow's dist artifacts, so its runs stall too. A PR looks like it is "just being slow" the entire time. browser-smoke (15) and codspeed-walltime (30) already carried timeouts; this gives the other four the same treatment, sized off a green run on main: job typical limit detect-changes 13s 10m build (slowest) 239s 20m (libjxl; leaves room for a cold image pull) test 53s 15m dist-size 47s 10m Additions only -- no existing line changes. release.yml's build matrix has the same gap and the same 6-hour exposure, but it is left for a follow-up: PR #63 is currently editing that job's `if:` and touching it here would conflict. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will degrade performance by 20.51%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
@jbocce - we sometimes get wedged runs - no idea what is causing it, but it seems to want to timeout. This just adds timeouts. It shouldn't change codspeed at all, but somehow we get random changes tehre. |
build (big-endian)wedged on #70 and satin_progressfor over 80 minutes while its nine sibling matrix legs finished in 58–239s. Nothing bounded it, so it was on course for GitHub's 6-hour default.That is worse than one slow leg.
fail-fastis off for that matrix by design, so a wedged leg keeps the whole run pending — along withtest,dist-size,browser-smokeandcodspeed-walltime, which allneeds: build.bench.ymlwaits on this workflow's dist artifacts, so its runs stall too. For the whole 80 minutes the PR just looked like it was being slow.browser-smoke(15) andcodspeed-walltime(30) already had timeouts. This gives the other four the same treatment, sized off a green run onmain(33674157431):detect-changesbuild(slowest leg)testdist-sizeThe
buildlimit is ~5× the slowest observed leg, with room for a cold emsdk image pull. The others sit in the same 10–35× range the two existing timeouts already use.Additions only — 20 lines, no existing line modified. Verified the file still parses and that no job is left unbounded.
Not included
release.yml's build matrix has the identical gap and the identical 6-hour exposure. Left for a follow-up on purpose: #63 is currently editing that job'sif:condition, and touching it here would conflict. Worth doing straight after #63 lands.🤖 Generated with Claude Code