fix: resolving FPs with SQL queries on various places#45
Merged
azurit merged 23 commits intocoreruleset:masterfrom Apr 13, 2026
Merged
fix: resolving FPs with SQL queries on various places#45azurit merged 23 commits intocoreruleset:masterfrom
azurit merged 23 commits intocoreruleset:masterfrom
Conversation
EsadCetiner
requested changes
Apr 12, 2026
Member
EsadCetiner
left a comment
EsadCetiner
left a comment
There was a problem hiding this comment.
Can you give a more descriptive PR name? fix: lots of FPs gives me no information as to what this PR is fixing from just a glance.
Same with the tests, the test descriptions are not very descriptive.
azurit
changed the title
EsadCetiner
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.