Skip to content

fix(integration): drop the removed Conductor integration from connect #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polylane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(integration): drop the removed Conductor integration from connect #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/commands/integration/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ type ConnectableType =
| 'devin'
| 'cursor'
| 'factory'
| 'conductor'
| 'capy'
| 'amp'
| 'linear'
Expand Down Expand Up @@ -114,7 +113,6 @@ const TYPE_OPTIONS: Array<{ value: ConnectableType; label: string; hint: string;
{ value: 'devin', label: 'Devin', hint: 'API key · coding agent', category: 'code-agent' },
{ value: 'cursor', label: 'Cursor', hint: 'API key · coding agent', category: 'code-agent' },
{ value: 'factory', label: 'Factory', hint: 'API key · coding agent', category: 'code-agent' },
{ value: 'conductor', label: 'Conductor', hint: 'API key · coding agent', category: 'code-agent' },
{ value: 'capy', label: 'Capy', hint: 'API key · coding agent', category: 'code-agent' },
{ value: 'amp', label: 'Amp', hint: 'access token · coding agent', category: 'code-agent' },
{ value: 'linear', label: 'Linear', hint: 'personal API key · issue tracking', category: 'issue-tracking' },
Expand Down Expand Up @@ -393,14 +391,6 @@ const CODE_AGENTS = {
link: 'https://app.factory.ai/settings/api-keys',
linkLabel: 'Create API key',
},
conductor: {
keyLabel: 'API key',
name: 'Conductor',
instructions:
'Create an API key in Conductor under Users > API keys. The key starts with sk_. Handed-off autofixes run as agents in Conductor Cloud workspaces on your account.',
link: 'https://app.conductor.build/users/api-keys',
linkLabel: 'Create API key',
},
capy: {
keyLabel: 'API key',
name: 'Capy',
Expand Down Expand Up @@ -1600,7 +1590,7 @@ export const integrationConnectCommand: Command = {
{
flag: '--api-key <key>',
description:
'API key (Datadog / Honeycomb / OpenStatus / Logfire project key / New Relic User key / LangSmith / Braintrust service token / incident.io / Amplitude / CircleCI personal API token / Devin / Cursor / Factory / Conductor / Capy / Amp access token / Linear)',
'API key (Datadog / Honeycomb / OpenStatus / Logfire project key / New Relic User key / LangSmith / Braintrust service token / incident.io / Amplitude / CircleCI personal API token / Devin / Cursor / Factory / Capy / Amp access token / Linear)',
type: 'string',
},
{ flag: '--secret-key <key>', description: 'Secret key (Amplitude only)', type: 'string' },
Expand Down
8 changes: 4 additions & 4 deletions test/integration-connect-category.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { isCLIError } from '../src/errors/base';
describe('typeOptionsForCategory', () => {
it('returns every option when no category is given', () => {
const all = typeOptionsForCategory(undefined);
assert.equal(all.length, 28);
assert.equal(all.length, 27);
});

it('narrows to exactly the observability integrations', () => {
Expand All @@ -37,7 +37,7 @@ describe('typeOptionsForCategory', () => {

it('narrows to exactly the code agents', () => {
const types = typeOptionsForCategory('code-agent').map((o) => o.value);
assert.deepEqual(types.sort(), ['amp', 'capy', 'conductor', 'cursor', 'devin', 'factory']);
assert.deepEqual(types.sort(), ['amp', 'capy', 'cursor', 'devin', 'factory']);
});

it('narrows to exactly the incident management and CI/CD integrations', () => {
Expand Down Expand Up @@ -95,9 +95,9 @@ describe('typeOptionsForCategory', () => {

describe('resolveTypeOptions', () => {
it('lets --type win over the filter', () => {
assert.equal(resolveTypeOptions('observability', true).length, 28);
assert.equal(resolveTypeOptions('observability', true).length, 27);
assert.equal(resolveTypeOptions('observability', false).length, 11);
assert.equal(resolveTypeOptions(undefined, false).length, 28);
assert.equal(resolveTypeOptions(undefined, false).length, 27);
});

it('rejects an unknown category even when --type is present', () => {
Expand Down
Loading