Skip to content

fix(sensor): seed deployment metadata via values drop-in; bump to 29.3.0 - #13

Merged
thathaneydude merged 2 commits into
mainfrom
topic/jacob.fiola/CLOUD-1577-metadata-values-drop-in
Nov 12, 2026
Merged

thathaneydude merged 2 commits into
mainfrom
topic/jacob.fiola/CLOUD-1577-metadata-values-drop-in

Conversation

@jmfiola

@jmfiola jmfiola commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Sensors paired with Fleet never received the Terraform deployment metadata (module identity, module version, traffic mirroring). Cloud-init applied it with corelightctl sensor configuration put after deploy, and the sensor rejects that call when Fleet manages its configuration. The step only logged a warning, so the fields stayed null.

The sensor modules now write the metadata as a corelightctl Helm values drop-in, which the existing single corelightctl sensor deploy -v reads:

# /etc/corelight/corelightctl-values.yaml.d/10-deployment-metadata.yaml
sensor-api:
  deploymentMetadata:
    terraformModule: aws/sensor
    terraformModuleVersion: v29.0.5-7
    cloudTrafficMirroringEnabled: "true"

/etc/corelight/deployment-metadata.yaml and the configuration put step are removed. Fleet pairing stays inline in corelightctl.yaml, and the sensor is deployed once. The variables and the omission rules for unknown or invalid values are unchanged.

Version: bumps VERSION to 29.3.0, so this merge publishes v29.3.0-1.

Compatibility: this depends on a sensor release whose chart reads these values. Older sensor versions ignore the drop-in and report the fields as null. Before this change, Fleet-paired sensors also reported null, and unpaired sensors got the metadata through configuration put. Keep this PR in draft until a compatible sensor release is available.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Release version bump (29.3.0)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Module migration
  • CI/CD update

Affected Modules

  • AWS modules
  • GCP modules
  • Azure modules
  • Shared modules
  • Examples
  • Tests
  • Documentation

Affected sensor paths: aws/sensor, aws/sensor-single, azure/sensor, azure/sensor-single and gcp/sensor, through modules/_shared/config/sensor.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run terraform fmt -recursive
  • I have run terraform validate on affected modules
  • I have updated the CHANGELOG.md (if applicable)

Testing

  • terraform test passes for _shared/config/sensor (15), aws/sensor (6), aws/sensor-single (6), azure/sensor (5), azure/sensor-single (1) and gcp/sensor (9). The updated shared tests fail against the previous template (9 of 15).
  • New assertions: the drop-in decodes to the expected sensor-api.deploymentMetadata values (including with Fleet pairing), runcmd is a single corelightctl sensor deploy -v, and no configuration put remains.
  • scripts/release/test_compute_next_tag.sh passes (19/19); compute-next-tag.sh emits v29.3.0-1.
  • terraform fmt -check -recursive and tflint --recursive pass. just docs-check reports modules/_shared/config/fleet/README.md out of date; that also happens on main without this change.

Additional Notes

Not yet deployed end to end with a sensor build that includes the matching chart change.

…rop-in

Fleet-paired sensors reject the post-deploy configuration put, so the
metadata never applied. Write it as a Helm values drop-in that the single
sensor deploy reads instead.
Deployment metadata through the values drop-in needs a 29.3 sensor.
@jmfiola jmfiola changed the title fix(sensor): seed deployment metadata through a corelightctl values drop-in fix(sensor): seed deployment metadata via values drop-in; bump to 29.3.0 Nov 9, 2026
@jmfiola
jmfiola marked this pull request as ready for review November 12, 2026 18:27
@thathaneydude
thathaneydude merged commit 10580b9 into main Nov 12, 2026
6 checks passed
@thathaneydude
thathaneydude deleted the topic/jacob.fiola/CLOUD-1577-metadata-values-drop-in branch November 12, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants