Repository navigation
fix(sensor): seed deployment metadata via values drop-in; bump to 29.3.0 - #13
Merged
thathaneydude merged 2 commits intoNov 12, 2026
Merged
Conversation
…rop-in Fleet-paired sensors reject the post-deploy configuration put, so the metadata never applied. Write it as a Helm values drop-in that the single sensor deploy reads instead.
Deployment metadata through the values drop-in needs a 29.3 sensor.
jmfiola
marked this pull request as ready for review
November 12, 2026 18:27
thathaneydude
approved these changes
Nov 12, 2026
thathaneydude
deleted the
topic/jacob.fiola/CLOUD-1577-metadata-values-drop-in
branch
November 12, 2026 18:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sensors paired with Fleet never received the Terraform deployment metadata (module identity, module version, traffic mirroring). Cloud-init applied it with
corelightctl sensor configuration putafter deploy, and the sensor rejects that call when Fleet manages its configuration. The step only logged a warning, so the fields stayed null.The sensor modules now write the metadata as a
corelightctlHelm values drop-in, which the existing singlecorelightctl sensor deploy -vreads:/etc/corelight/deployment-metadata.yamland theconfiguration putstep are removed. Fleet pairing stays inline incorelightctl.yaml, and the sensor is deployed once. The variables and the omission rules for unknown or invalid values are unchanged.Version: bumps
VERSIONto29.3.0, so this merge publishesv29.3.0-1.Compatibility: this depends on a sensor release whose chart reads these values. Older sensor versions ignore the drop-in and report the fields as null. Before this change, Fleet-paired sensors also reported null, and unpaired sensors got the metadata through
configuration put. Keep this PR in draft until a compatible sensor release is available.Type of Change
29.3.0)Affected Modules
Affected sensor paths:
aws/sensor,aws/sensor-single,azure/sensor,azure/sensor-singleandgcp/sensor, throughmodules/_shared/config/sensor.Checklist
terraform fmt -recursiveterraform validateon affected modulesTesting
terraform testpasses for_shared/config/sensor(15),aws/sensor(6),aws/sensor-single(6),azure/sensor(5),azure/sensor-single(1) andgcp/sensor(9). The updated shared tests fail against the previous template (9 of 15).sensor-api.deploymentMetadatavalues (including with Fleet pairing),runcmdis a singlecorelightctl sensor deploy -v, and noconfiguration putremains.scripts/release/test_compute_next_tag.shpasses (19/19);compute-next-tag.shemitsv29.3.0-1.terraform fmt -check -recursiveandtflint --recursivepass.just docs-checkreportsmodules/_shared/config/fleet/README.mdout of date; that also happens onmainwithout this change.Additional Notes
Not yet deployed end to end with a sensor build that includes the matching chart change.