fix: allow for ipv6 address for prometheus - #266
Merged
Conversation
… ipv6 addresses Signed-off-by: Euan Haahr <euan@haahr.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
if you set prometheus parameters from and ipv4 address "0.0.0.0:91543" to a ipv6 address "[::]:91543" the template will fail to render.
Currently the port generation code is assuming the second value in the split is the port which will work on ipv4 but wont work on ipv6 addresses.
The code now picks the last colon split in the list which should always be the port and will work for both ipv4 and ipv6.
What would be better instead of string splitting would be to use the sprig urlParse function
example:
but this function is also broken for ipv6 it seems.
Checklist: