Skip to content

Group chat members in a compact header popover - #710

Closed
pratikbuilds wants to merge 5 commits into
corbitsdev:mainfrom
pratikbuilds:cl-697-member-popover
Closed

pratikbuilds wants to merge 5 commits into
corbitsdev:mainfrom
pratikbuilds:cl-697-member-popover

Conversation

@pratikbuilds

Copy link
Copy Markdown
Contributor

Groups the chat header’s member avatars and invite control into a compact Members button. The popover shows the roster with hover/focus highlighting, matching agent and human preview sizes, and a shared popover menu for Edit agent. Settings remains separate; the duplicate live-presence stack and header Remove action are removed.

Also adds a read-only owner projection to workbench responses so the owner appears when absent from the participant roster. This backend/API change remains in the draft; resolve whether to remove it to keep the change UI-only before marking ready.

Validation

  • 77 focused tests passed across member UI, workspace composition, avatar roster, and backend owner suites.
  • Chat UI typecheck and diff whitespace check passed.
  • Repository pre-push checks passed (formatting, lint, typecheck, and test pipeline, including the web production build). Lint reported 10 warnings and no errors.
  • A fresh browser walkthrough and a separate full bun run check have not been completed for this draft.

Refs #697.

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closing: every file this draft touches has since been deleted from main, so there is no rebase path.

The duplicate presence stack this removes no longer exists, and a Members surface already lives in workbench settings (apps/web/src/chat/strings.ts). If the compact header Members popover is still wanted, it is a fresh change against apps/web/src/chat — worth a ticket that also settles whether the read-only owner projection is in scope, which this draft left open. Branch left in place for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants