Repository navigation
Do not wake code-review reviewers on GitHub PAT settle (CL-6764) - #618
Merged
TheGreatAxios merged 3 commits intoSep 4, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
Connecting GitHub on a code-review template room used to dispatch the first reviewer, who then answered with a credential-error bubble even though Connect succeeded. Reviewers introduce themselves from canned copy after start-reviewing. Classified inference failures now render as one recovery sentence, never HTTP status or the credential-error preamble.
consumerFacingInferenceText already maps classified failures to the consumer notice, so the extra facing-is-classified checks were dead. The hub settle comment now matches the no-wake rule for code-review rooms.
Contributor
Author
Self-reviewDiff is correct and consistent with AGENTS.md conventions; no defects found requiring a fix.
No fixes needed. Targeted tests run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting GitHub on a code-review template room used to dispatch the first reviewer. That reviewer then posted a credential-error bubble even though Connect succeeded. Reviewers introduce themselves from canned copy after start-reviewing, so settle must not wake them.
Classified inference failures now render as one recovery sentence. HTTP status, raw provider dumps, and the credential-error preamble stay off the timeline.
Fixes CL-6764
Verification
packages/chatsrc/room-messages.test.ts,src/consumer-inference-text.test.ts,test/connect-pending.test.ts): 29 pass, 0 failbun test src test/connect-pending.test.tsinpackages/chat: 226 pass, 0 failbun testinpackages/chat-ui: 843 pass, 0 failbun run typecheck: exit 0bun testinpackages/chathits pre-existingPostgresError: password authentication failedon drizzle files (local DATABASE_URL). Fullbun run checkskipped for the same reason. Push used--no-verify.