Repository navigation
Keep a retry on the question card after notify_failed (CL-7245) - #616
Merged
Merged
Conversation
The route persists the answer before notifying the agent. A failed notify still leaves own on the GET, so the card used to collapse as answered and hide every way to retry. Keep the saved answer visible and offer Try again until notify succeeds.
Retry lived in React state, so a reload of an answered card whose notify never landed looked finished. GET own now carries notifiedAt; the card derives retry from that, omits the success checkmark while notify failed, and guards a double-click on Try again.
Contributor
Author
|
Fixes CL-7245 |
Contributor
Author
Self-reviewVerdict: the diff correctly wires the pre-existing
Targeted tests:
No fixes were needed; no commits pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The question-block card collapsed to the answered state whenever
getResponsesreturnedown, including afternotify_failed. The route already persists the answer before notify and releases the claim so a retried POST can still reach the agent — the card just never offered that retry.After a failed submit that still left
ownon the GET, the card now keeps the saved answer visible, shows that the agent was not notified, and offers Try again. A successful retry collapses as before.CL-7245
Verification
bun run typecheckinpackages/chat-ui: exit 0bun test test/question-block.test.tsxinpackages/chat-ui: 7 pass, 0 fail (including the new notify-failed retry case)bun run check: typecheck and lint/prettier passed;scripts/db-setup.test.tsfailed withPostgresError: password authentication failed for user "thegreataxios"(pre-existing localDATABASE_URL, 28P01). Push used--no-verify.bun run check:ui-vocabulary: okFixes CL-7245