Repository navigation
Parse stream JSON with arktype and surface dropped messages (CL-6837) - #613
Merged
TheGreatAxios merged 2 commits intoSep 4, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-6837-chat-stream-json-parse-drop-leaves-the-room-silent-until
branch
from
September 4, 2026 04:52
d16cf45 to
3985b77
Compare
Contributor
Author
Self-reviewRebased cleanly onto CL-6476's latest (49f4c98, chat.settings reportError) with no conflicts. Reviewed the resulting delta against AGENTS.md; no confirmed defects found.
Targeted tests (packages/chat-ui):
|
A malformed live chat.message currently vanishes until the next poll, and the EventSource boundary uses JSON.parse instead of arktype. These tests pin an immediate toast and feed refresh instead of a silent wait.
The EventSource handler caught JSON.parse failures and forwarded the raw string, so ChatMessageEventData missed and the room stayed silent until a later poll. Parse at that boundary with arktype, toast, and refresh the feed immediately. chat.settings handling from CL-6476 is unchanged.
TheGreatAxios
force-pushed
the
cl-6837-chat-stream-json-parse-drop-leaves-the-room-silent-until
branch
from
September 4, 2026 05:49
3985b77 to
753b54d
Compare
TheGreatAxios
changed the base branch from
cl-6476-connect-cards-need-a-live-chatsettings-subscriber-card-stays
to
main
September 4, 2026 05:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live chat.message whose payload failed JSON.parse was forwarded as a raw string, failed ChatMessageEventData, and vanished until the next poll — which never runs while the stream is still open. The EventSource boundary now parses with arktype (string.json.parse). A miss is not forwarded: it toasts and refreshes the feed immediately.
chat.settings handling from CL-6476 is unchanged.
Fixes CL-6837
Stacked on #610.
Verification