Skip to content

Keep Advanced collapsed after a draft fail and name the CTA blocker - #611

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-6751-agent-create-auto-opens-advanced-and-blocks-get-started-after
Sep 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-6751-agent-create-auto-opens-advanced-and-blocks-get-started-after

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Fixes CL-6751

Stacked on CL-6749. A failed Myra draft already shows a consumer sentence and refId; this change stops that failure from silently opening Advanced, puts the blocker on the disabled primary instead of "Get started", and stops model help from claiming Myra will pick one after drafting already failed.

  • Draft failure keeps Advanced collapsed
  • Disabled primary names the blocker (Open Advanced and write a system prompt to continue.)
  • Model help after a failed draft: workbench default, not "Myra picks one"
  • CL-6749 envelope/refId rendering is unchanged

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review

Verdict: the change is minimal, correctly scoped to CL-6751 (keep Advanced collapsed after a failed draft, name the blocker on the disabled primary, drop the stale "Myra picks one" model help), and matches AGENTS.md conventions. No defects found; no code changes made.

  • Advanced stays collapsed on draft failure (setAdvancedOpen(true) removed from the catch path) — CONFIRMED-FIXED (already correct in the PR as submitted; nothing further to change).
  • Disabled primary now shows blocked ?? "Get started" instead of a separate helper paragraph — DISMISSED: matches the stated design intent (disabled label names the blocker) and is covered by the updated tests.
  • Model help copy swaps "Myra picks one" for the workbench-default sentence once draftFailed is true — DISMISSED: correct, verified against the test asserting "Myra picks one" is absent post-failure.
  • exactOptionalPropertyTypes, bare catches, as T on untrusted input, fallbacks-beside-new-paths: none introduced by this diff.
  • Comments were updated to describe the new "keeps Advanced collapsed" behavior rather than restating code — fine.

Targeted tests run:

  • bun test test/create-agent-panel.test.tsx (from apps/web) — 11 pass, 0 fail.
  • bun run typecheck — clean.

No commits pushed; nothing to fix.

@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

CL-6751

A failed draft must keep Advanced collapsed, put the blocker on the
disabled primary instead of "Get started", and stop promising Myra
will pick a model after drafting already failed.
…CL-6751)

A failed Myra draft already has a consumer error and refId. Forcing
Advanced open hid that the person still had to write a system prompt,
and the primary kept saying "Get started" while disabled. Model help
also stopped claiming Myra would pick one after drafting already failed.
@TheGreatAxios
TheGreatAxios changed the base branch from cl-6749-agent-create-draft-failure-shows-something-went-wrong-with to main September 4, 2026 05:49
@TheGreatAxios
TheGreatAxios force-pushed the cl-6751-agent-create-auto-opens-advanced-and-blocks-get-started-after branch from 7a805bf to e4cdf65 Compare September 4, 2026 05:49
@TheGreatAxios
TheGreatAxios merged commit 0938a70 into main Sep 4, 2026
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant